Skip to content

Rely on Exception#message rather than overloading with attr_reader #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josh-lauer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rely on Exception#message rather than overloading with attr_reader #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/dropbox/errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
module Dropbox
# Thrown when Dropbox::Client encounters an error unrelated to the API.
class ClientError < StandardError
attr_reader :message

def self.invalid_access_token
self.new("Invalid access token")
end
Expand All @@ -24,8 +22,6 @@ def to_s

# Thrown when the API returns an error response.
class ApiError < StandardError
attr_reader :message

def initialize(response)
if response.content_type.mime_type == 'application/json'
@message = JSON.parse(response)['error_summary']
Expand Down