[RFC 74: Restructure] General reorganisation#8260
Closed
kaedroho wants to merge 12 commits intowagtail:mainfrom
Closed
[RFC 74: Restructure] General reorganisation#8260kaedroho wants to merge 12 commits intowagtail:mainfrom
kaedroho wants to merge 12 commits intowagtail:mainfrom
Conversation
Manage this branch in SquashTest this branch here: https://kaedrohogeneral-reorg-griuf.squash.io |
kaedroho
changed the title
zerolab
referenced
this pull request
Apr 6, 2022
- add documentation for WAGTAILADMIN_BASE_URL - ensure that WAGTAILADMIN_BASE_URL is used via a util so that it can fallback from request - resolves #3248 - remove settings URL from pagination template - not required for query string URLs
Member
|
With the RFC 74 work partially completed and this PR every old, I think it's best to close this PR. We will continue discussions in the core team meetings if a fresh momentum on RFC74 work is needed. Several other PRs related to this have been rebased & merged recently, plus the original work that was done. Thanks @kaedroho for the incredible work on this and helping push for a cleaner code structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 74: Core module reorganisation #74