This repository was archived by the owner on Dec 11, 2021. It is now read-only.
Add labelClass option to block definition and closedOnAdd option#13
Open
joeyjurjens wants to merge 2 commits intowagtail-deprecated:masterfrom
joeyjurjens:label_class_option
Open
Add labelClass option to block definition and closedOnAdd option#13joeyjurjens wants to merge 2 commits intowagtail-deprecated:masterfrom joeyjurjens:label_class_option
joeyjurjens wants to merge 2 commits intowagtail-deprecated:masterfrom
joeyjurjens:label_class_option
Conversation
joeyjurjens
changed the title
vsalvino
reviewed
Nov 2, 2020
| !!blockDefinition.required && 'required')}> | ||
| <label className='field__label' htmlFor={getFieldName(blockId)}> | ||
| !!blockDefinition.required && 'required', )}> | ||
| <label className={classNames('field__label', blockDefinition.labelClass)} htmlFor={getFieldName(blockId)}> |
There was a problem hiding this comment.
This comment is for react-streamfield team: If there is some way to get className on the div, that would probably also work (higher level in the dom tree is usually more "future-proof"). Or is there already a recommended way to accomplish customizing the HTML output?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added this option because I've blocks where I don't need to show the label, if we add an optional labelClass option we can easily hide/style them. Same goes for some nested blocks, why show them all instantly. I think an option for that would be very useful too!
Hope you guys think those are good options too! :)