Skip to content

If clipboard operations throw an exception, don't crash#300

Merged
waf merged 1 commit into
mainfrom
clipboard-exception-should-not-throw-exception
Jun 15, 2026
Merged

If clipboard operations throw an exception, don't crash#300
waf merged 1 commit into
mainfrom
clipboard-exception-should-not-throw-exception

Conversation

@waf

@waf waf commented Jun 15, 2026

Copy link
Copy Markdown
Owner

If clipboard operations throw an exception, don't crash. However, if the exception is because the user is on Linux and xsel is not installed, then the clipboard operations will never work, so we should throw an exception telling the user to install xsel.

The exception is on Linux if xsel is not installed. Then, clipboard operations will _never_ work so we should thrown an exception telling the user to install xsel.
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.2%. Comparing base (f59d789) to head (e410516).

Files with missing lines Patch % Lines
src/PrettyPrompt/Panes/CodePane.cs 95.2% 1 Missing ⚠️
src/PrettyPrompt/Prompt.cs 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #300     +/-   ##
=======================================
+ Coverage   85.8%   86.2%   +0.4%     
=======================================
  Files         47      47             
  Lines       4030    4063     +33     
  Branches     676     677      +1     
=======================================
+ Hits        3460    3505     +45     
+ Misses       404     392     -12     
  Partials     166     166             

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waf waf merged commit 20b9605 into main Jun 15, 2026
3 checks passed
@waf waf deleted the clipboard-exception-should-not-throw-exception branch June 15, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant