fix(ui): rename duplicate trainFamily binding in forecast page

[w7-mgfcode]

Summary

• Renames the PRP-31 derived trainFamily (L120, sourced from useJobFeatureMetadata) to loadedTrainFamily.
• Updates the single consumer at L497–498 (ModelFamilyBadge in the "Model details" collapsible).
• The PRP-37 Slice C train-card form state (trainFamily at L68 via useState) keeps its name.

Fixes #307 — without this, Babel/Vite reject forecast.tsx with Cannot redeclare block-scoped variable 'trainFamily'; tsc reports TS2451 at both sites; the Forecast page (/visualize/forecast) never mounts.

Discovered while running the PRP-37 Task 26 dogfood against the merged dev (5e86b6f).

Test plan

• tsc --noEmit -p tsconfig.app.json no longer emits the two TS2451 redeclaration errors at forecast.tsx:68/120.
• vitest run over src/components/forecast-intelligence/, src/components/charts/backtest-horizon-buckets-chart.test.tsx, src/lib/feature-frame-utils.test.ts, src/lib/horizon-bucket-utils.test.ts — 81/81 pass.
• Manual dogfood (vite --host 0.0.0.0 + Playwright on /snap/bin/chromium): the Forecast Visualization page now renders the PRP-37 Train-a-new-model card (Family segmented control, Model select, Feature frame V1/V2 picker, Store/Product/Date inputs); 9/9 PRP-37 surfaces pass.

[sourcery-ai]

Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2efd1c68-f6b3-40e4-9ed9-41c52db0b0bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/forecast-train-family-duplicate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}