docs(prp): refresh PRP-36 after Feature Frame V2

[w7-mgfcode]

Tracking: #295 (Forecast Intelligence roadmap). Related: #299 (PRP-35 / V2 backtesting deferral).

Why

Executes the PRP-36 Task 1 Contract Refresh gate against dev @ f2bf7c8
(post PR #300 merge). Captures what PRP-35 actually shipped vs what PRP-36
assumed, and patches PRP-36 in-place so its execution can start cleanly.

Per PRP-36 line 1286 (its own gate): "If ANY assumption above fails Task 1
verification: open a chore(docs): refresh PRP-36 against PRP-35 final contract PR that edits THIS PRP file in place, THEN proceed to Task 2."

Drift detected

Probed 5 files cited by PRP-36 (contract_v2.py, rows_v2.py,
forecasting/schemas.py, forecasting/service.py,
scenarios/feature_frame.py) plus v2_loaders.py and backtesting/service.py.

Assumption	Status
1-6, 8, 9	✅ pass
7 — backtesting V2 dispatch at lines 493/553	❌ NOT SHIPPED — deferred to #299
10 — DEFAULT_V2_GROUPS ordering	⚠️ membership correct, CALENDAR at position 2 not 4

Changes

New file: PRPs/ai_docs/prp-35-final-contract-snapshot.md — authoritative
snapshot of PRP-35's final contract on dev @ f2bf7c8. Captures all 11
assumption verifications, the actual default 38-column manifest, the
shipped v2_pinned_constants() dict (11 keys), the v2_loaders.py export
surface, and a per-task readiness table.

Patched: PRPs/PRP-36-forecast-intelligence-B-model-zoo-backtesting.md

• Item 7 — rewritten as VERIFIED FAILED with the deferral context, cites feat(forecast): add feature frame v2 (PRP-35) #299.
• Task 8 — re-scoped to V1 fold path only; dropped "PRESERVE the V1/V2
  dispatch PRP-35 Task 13 added" (there is no V1/V2 dispatch to preserve);
  dropped the matching log-line clause. V2 bucket-metric emission lands
  jointly with feat(forecast): add feature frame v2 (PRP-35) #299.
• Item 10 — DEFAULT_V2_GROUPS ordering corrected to
  (TARGET_HISTORY, CALENDAR, ROLLING, TREND, PRICE_PROMO, LIFECYCLE);
  noted that ordering is documentation-only since the manifest drives
  column order.

No implementation code touched. PRP-36 execution remains gated until this
docs PR lands.

Scope verification

• git diff --check → no whitespace errors
• git diff --stat → 2 files changed, 310 insertions(+), 9 deletions(-)
• Only PRPs/PRP-36-…md and PRPs/ai_docs/prp-35-final-contract-snapshot.md

Test plan

• CI green (docs-only; ruff / mypy / pyright / pytest unaffected by PRPs/**).
• Reviewer confirms snapshot § 10 (backtesting deferral) matches the PRP-35 PR body of feat(forecast): add feature frame v2 #300.
• After merge, PRP-36 Task 2 onward is unblocked.

Summary by Sourcery

Refresh PRP-36 documentation against the actual PRP-35 Feature Frame V2 contract and record the one failed assumption so downstream PRP-36 work can proceed cleanly.

Documentation:

• Add an authoritative snapshot document of the final PRP-35 Feature Frame V2 contract, including assumptions, defaults, and backtesting status.
• Update PRP-36 to mark the backtesting V2 dispatch assumption as failed/deferred, rescope the backtesting bucket-metrics task to the V1 path only, and correct the documented DEFAULT_V2_GROUPS ordering.

[sourcery-ai]

Reviewer's Guide

Docs-only PR that (1) adds an authoritative snapshot of the final PRP-35 feature-frame contract and (2) patches PRP-36’s assumptions and Task 8 scope to match what actually shipped, explicitly documenting the deferral of backtesting V2 dispatch and correcting DEFAULT_V2_GROUPS ordering.

Flow diagram for PRP-36 contract refresh and V2 dispatch deferral

flowchart TD
    A[PRP-35 shipped on dev @ f2bf7c8] --> B[PRP-36 Task1 Contract Refresh probe]
    B --> C{Assumption 7 holds? backtesting V2 dispatch}
    C -- No: deferred --> D[Create prp-35-final-contract-snapshot]
    D --> E[Patch PRP-36 assumption 7 as VERIFIED FAILED]
    E --> F[Rescope Task 8 to V1 fold path only]
    F --> G[Correct DEFAULT_V2_GROUPS ordering]
    G --> H[Backtesting V2 dispatch + V2 bucket metrics tracked in issue_299]
    H --> I[PRP-36 Task2 onward unblocked after this docs PR merge]

Loading

File-Level Changes

Change	Details	Files
Constrain PRP-36 Task 8 to the existing V1 backtesting fold path and decouple it from deferred V2 dispatch work.	Clarify that Task 8 wires bucket metrics only on the current V1 fold path in backtesting/service.py. Explain that V2 backtesting dispatch and V2 bucket-metric emission are deferred and land with issue feat(forecast): add feature frame v2 (PRP-35) #299, and should not be added in this task. Remove the outdated instruction to preserve a non-existent V1/V2 dispatch block and adjust logging expectations to only add bucket-count logging until V2 dispatch ships.	PRPs/PRP-36-forecast-intelligence-B-model-zoo-backtesting.md
Update PRP-36’s contract-assumption section to reflect the actually shipped PRP-35 behavior, including failed backtesting V2 dispatch and corrected DEFAULT_V2_GROUPS ordering.	Mark assumption 7 as a verified failure, documenting that backtesting V2 dispatch was deferred from PRP-35 and pointing to issue feat(forecast): add feature frame v2 (PRP-35) #299 and the architectural mismatch around bundles vs BacktestConfig. Clarify the current backtesting/service.py behavior (V1 builders only, no bundle.metadata or feature_frame_version usage) and that Task 8 is now scoped to V1 only, with V2 work tied to feat(forecast): add feature frame v2 (PRP-35) #299. Correct assumption 10 to the actual DEFAULT_V2_GROUPS ordering with CALENDAR in second position, and note that group ordering is documentation-only with the manifest as the canonical column source, referencing the snapshot section for details.	PRPs/PRP-36-forecast-intelligence-B-model-zoo-backtesting.md
Introduce a dedicated PRP-35 final-contract snapshot document capturing the probed feature-frame V2 surface, manifest, metadata, and assumption verification outcomes.	Document the import surface and constants for the V2 feature-frame contract, including FeatureGroup, DEFAULT_V2_GROUPS, column counts, and the default 38-column manifest. Record the actual v2_pinned_constants() shape (11 keys), TrainRequest V2 fields and validator, bundle metadata shapes for V1 and V2, and v2_loaders export surface. Describe the shipped scenarios V2 dispatch behavior, explicitly call out that backtesting V2 dispatch did not ship and was deferred to feat(forecast): add feature frame v2 (PRP-35) #299, and summarize which of the 11 PRP-36 assumptions passed, failed, or drifted, plus required PRP-36 patches. Provide this snapshot as the single source of truth for PRP-36 Task 1 and PRP-37 Task 1 going forward.	PRPs/ai_docs/prp-35-final-contract-snapshot.md

Possibly linked issues

• epic(forecast): Forecast Intelligence roadmap (PRP-35/36/37) #295: PR performs the PRP-36 Contract Refresh gate explicitly tracked under the Forecast Intelligence roadmap umbrella issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f5c10d2-d4ab-411a-b02e-209e8058200a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch docs/refresh-prp36-after-prp35

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}