docs(docs): refresh batch-parallel-execution INITIAL post-PRP-33 (#280)#283
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefreshes the INITIAL batch parallel-execution PRP doc to align with the already-shipped PRP-33 batch-runner MVP, clarifying that the DB columns are already present, renaming API schema types to match the current code, and updating backend/frontend/test touchpoint descriptions accordingly. Entity relationship diagram for activated batch_job parallel-execution columnserDiagram
batch_job {
int max_parallel
int running_items
int cancelled_items
string status
}
batch_job ||--o{ batch_job_item : has
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the header
Scope:line you still describe the batch-runner MVP as "(unbuilt)", which is now stale given the dependency has shipped; consider updating that phrase to avoid confusion about the current state of the MVP. - In the
cancelled_itemsdescription you mention "onceDELETE /batch/{id}lands"; it might help to be explicit whether this INITIAL includes that route or if it is expected from a separate PRP, so readers understand when writes to this counter actually begin.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the header `Scope:` line you still describe the batch-runner MVP as "(unbuilt)", which is now stale given the dependency has shipped; consider updating that phrase to avoid confusion about the current state of the MVP.
- In the `cancelled_items` description you mention "once `DELETE /batch/{id}` lands"; it might help to be explicit whether this INITIAL includes that route or if it is expected from a separate PRP, so readers understand when writes to this counter actually begin.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary
max_parallel,running_items,cancelled_itemsonbatch_joband schema classesBatchSubmitRequest/BatchSubmitResponse.Changes
PRP-33 batch-runner MVP (merged in #281).BatchCreateRequest→BatchSubmitRequest,BatchResponse→BatchSubmitResponse(matchesapp/features/batch/schemas.py:116,164).models.py/schemas.py(they are shipped by PRP-33).NEW (this INITIAL)annotations preserved (test_runner.py,test_routes_cancel.py,test_runner_chaos.pyare genuinely net-new).Test plan
grep -nE "(BatchCreateRequest|BatchResponse[^.]|not yet scaffolded|NEW — owned by MVP)" PRPs/INITIAL/INITIAL-batch-parallel-execution.mdreturns empty.Summary by Sourcery
Refresh the batch parallel-execution INITIAL PRP to align with the shipped batch-runner MVP and forward-compat schema.
Documentation: