Cue settings should require colon and value in the syntax#542
Open
Cue settings should require colon and value in the syntax#542
Conversation
Contributor
Author
|
This change has no normative change because each defined cue setting requires the colon and value already. |
|
zcorpan marked as non substantive for IPR from ash-nazg. |
gkatsev
approved these changes
Mar 16, 2026
zcorpan
force-pushed
the
zcorpan/cue-settings-require-colon
branch
from
0c7eafc to
f4429f1
Compare
nigelmegitt
reviewed
Mar 18, 2026
Contributor
nigelmegitt
left a comment
nigelmegitt
left a comment
There was a problem hiding this comment.
Any reason not to allow optional whitespace either side of the colon?
Contributor
The fewer options the better in an already complex specification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541
Preview | Diff