Add a definition of "video viewport" and how it relates in HTML5 to object size resolution.#434
Add a definition of "video viewport" and how it relates in HTML5 to object size resolution.#434silviapfeiffer wants to merge 4 commits intow3c:gh-pagesfrom
Conversation
…bject size resolution.
| <h3 id="video-viewport">Video viewport</h3> | ||
|
|
||
| <p>The <dfn lt="video viewport">video viewport</dfn> is the video's rendering area which in the case | ||
| of HTML5 is defined by the |video|'s <a>concrete object size</a>.</p> |
There was a problem hiding this comment.
The href for the concrete object size link is https://drafts.csswg.org/css-images-3/#concrete-object-size but the spec is on /TR at https://www.w3.org/TR/css3-images/#concrete-object-size - any reason not to use the latter?
There was a problem hiding this comment.
That's what bikeshed picked for us. I'll added an explicit ref note so autolinks for preparing the /TR spec will link to the /TR spec.
Since these refer to the viewport use of CSS, but we need them here to refer to the video viewport.
|
@nigelmegitt could I get a review on this PR? |
nigelmegitt
left a comment
nigelmegitt
left a comment
There was a problem hiding this comment.
Complex to review, thanks for your patience. There's one link I found that points to an ED when there's a CR.
Looking for places where video is used when video viewport is meant, I found instances on lines 921, 938, 967, 1074, 1082, 1196, 1205, 1212, 1387, 1964, 4552, 4555, 4601, 4694, 4700, 5980, 6004 and 6010 of this pull request branch. Since the key issue being fixed here is confusion between video and video viewport, please could you step through those and fix them @silviapfeiffer ? You might think there's a good reason for some of them to be the way they are, but I couldn't spot one.
| <h3 id="video-viewport">Video viewport</h3> | ||
|
|
||
| <p>The <dfn lt="video viewport">video viewport</dfn> is the video's rendering area which in the case | ||
| of HTML5 is defined by the |video|'s <a spec=css-images-3>concrete object size</a>.</p> |
There was a problem hiding this comment.
The concrete object size link points to the CSS3 images ED rather than the CR at https://www.w3.org/TR/css3-images/#concrete-object-size where the definition is the same.
|
Thanks for taking the time for this in-depth review! |
2 participants
Addresses #375