Properly handle unresolvable shortname edge cases#2065
Merged
Conversation
deniak
requested changes
Mar 17, 2026
deniak
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves potential for server crashes when no suitable link is found in the value for "This version" under "More details about this document". There are 2 commits initially in the PR, one resolving an edge case for the
validateAPI, the other for themetadataAPI.Changes in addition to the fixes themselves:
generic.shortname.not-foundl10n string to be used by theif (!shortname)code path inSpecberus#getPreviousVersioninvalidator.jstests/docs/failures/2021-wd-no-this-link.html, largely based ontests/docs/2021-wd.htmlwith the removal of thehrefattribute from theatag under the This VersionddexpectMetadataFailurefunction totest/rules.jsand uses it when iterating newfailuresarray withinBasicstests (as it seems we were never testing any failure edge cases for the metadata API)