Skip to content

Improve test fromRdf#t0027. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidlehn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve test fromRdf#t0027. #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
020c9df
Improve test fromRdf#t0027.
davidlehn Oct 29, 2025
53fa13c
Restore True and False tests.
davidlehn Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/fromRdf/0027-in.nq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@

<http://example.com/boolean-object> <http://example.com/example> "True"^^<http://www.w3.org/2001/XMLSchema#boolean> .
<http://example.com/boolean-object> <http://example.com/example> "False"^^<http://www.w3.org/2001/XMLSchema#boolean> .
<http://example.com/boolean-object> <http://example.com/example> "notnative"^^<http://www.w3.org/2001/XMLSchema#boolean> .
Copy link
Contributor

@pchampin pchampin Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to add a comment to explain the rationale of testing "True" and "False",
and defusing the misunderstanding that they should be treated specifically.

Suggested change
<http://example.com/boolean-object> <http://example.com/example> "notnative"^^<http://www.w3.org/2001/XMLSchema#boolean> .
# NB: the two values above ("True" and "False") are *not* in the lexical space of xsd:bool, so they should be treated as any other invalid lexical form (like "notnative" below)
<http://example.com/boolean-object> <http://example.com/example> "notnative"^^<http://www.w3.org/2001/XMLSchema#boolean> .


<http://example.com/number-native> <http://example.com/example> "1"^^<http://www.w3.org/2001/XMLSchema#integer> .

<http://example.com/number-object> <http://example.com/example> "0.1e999999999999999"^^<http://www.w3.org/2001/XMLSchema#double> .
<http://example.com/number-object> <http://example.com/example> "+INF"^^<http://www.w3.org/2001/XMLSchema#double> .
<http://example.com/number-object> <http://example.com/example> "-INF"^^<http://www.w3.org/2001/XMLSchema#double> .

<http://example.com/number-object> <http://example.com/example> "notnative"^^<http://www.w3.org/2001/XMLSchema#integer> .
<http://example.com/number-object> <http://example.com/example> "notnative"^^<http://www.w3.org/2001/XMLSchema#double> .
12 changes: 12 additions & 0 deletions tests/fromRdf/0027-out.jsonld
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
{
"@type": "http://www.w3.org/2001/XMLSchema#boolean",
"@value": "False"
},
{
"@type": "http://www.w3.org/2001/XMLSchema#boolean",
"@value": "notnative"
}
]
},
Expand All @@ -46,6 +50,14 @@
{
"@type": "http://www.w3.org/2001/XMLSchema#double",
"@value": "-INF"
},
{
"@type": "http://www.w3.org/2001/XMLSchema#integer",
"@value": "notnative"
},
{
"@type": "http://www.w3.org/2001/XMLSchema#double",
"@value": "notnative"
}
]
}
Expand Down
Loading