Rewrite the spec with references to the Model section#222
Rewrite the spec with references to the Model section#222
Conversation
Fix plural references, ex: [=user agent=]s -> [=user agents=] Use a consistent range syntax, ex: [0 .. 1] Capitalize "Interface" and "Enum" in section headers Replace smart quotes Linkify some unlinked references Always include "attribute" in <dt> of attribute tables Use `backticks` instead of <code> tags Use <h2> for top-level section headers Use set/let/initialize consistently Reorder [=queue a global task=] parameters to match the definition Change [=queue a task=] to [=queue a global task=] Always pass a global object to [=current high resolution time=]
The algorithm asserts that gamepad.[[touches]] is empty, but there is no mechanism to clear it.
The internal slots table says the initial value is `false`, but it is always overwritten with `true` in the steps for [=a new `Gamepad`=].
The [=constructing a new GamepadHapticActuator=] steps create the new actuator but never return it.
index.html
Outdated
| responsible for recognizing when an [=input control layout=] | ||
| <dfn data-lt="corresponds with">corresponds with a standard | ||
| layout</dfn>, meaning the relative positions and orientations of its | ||
| input controls are close enough to the standard layout that a user can |
There was a problem hiding this comment.
Am I misreading, or "so" is missing here?
| input controls are close enough to the standard layout that a user can | |
| input controls are close enough to the standard layout so that a user can |
There was a problem hiding this comment.
I think omitting "so" is correct but I'm not satisfied with this definition and I think it should be rewritten to be clearer.
Maybe split it into two sentences:
The user agent is responsible for recognizing when an input control layout corresponds with a standard layout, meaning gamepads with this layout can be used interchangeably with other gamepads with layouts that correspond with the same standard layout. The user agent SHOULD consider a layout to correspond with a standard layout if its input controls have approximately the same relative positions and orientations as input controls described in the standard layout.
| <li>Let |rawAxis| be the [=axis=] at index |rawAxisIndex| of the | ||
| [=axis list=]. |
There was a problem hiding this comment.
Can we set it just like this?
| <li>Let |rawAxis| be the [=axis=] at index |rawAxisIndex| of the | |
| [=axis list=]. | |
| <li>Let |rawAxis| be [=axis list=][|rawAxisIndex|]. |
There was a problem hiding this comment.
I think this doesn't work because [=axis list=] doesn't refer to a specific list, maybe like this:
- Let |axisList| be the [=axis list=] of the [=gamepad=] represented by |gamepad|.
- [=list/For each=] |sourceIndex| of the [=list/indices=] of |axisList|:
- Let |mappedIndex| be |gamepad|.[[axisMapping]][|sourceIndex|].
- Set |gamepad|.[[axes]][|mappedIndex|] to the current [=normalized axis value=] for |axisList|[|sourceIndex|].
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
index.html
Outdated
| values. | ||
| </p> | ||
| <p> | ||
| A [=gamepad=] has a <dfn>gamepad identifier string</dfn>, a |
There was a problem hiding this comment.
consider just doing:
| A [=gamepad=] has a <dfn>gamepad identifier string</dfn>, a | |
| A [=gamepad=] has a <dfn data-for="gamepad">identifier string</dfn>, a |
And then references via [=gamepad/identifier string=]
| <td> | ||
| A {{GamepadHapticActuator}} object capable of generating a haptic | ||
| effect that vibrates the entire gamepad | ||
| The [=gamepad=]'s [=vibration actuator=] |
There was a problem hiding this comment.
| The [=gamepad=]'s [=vibration actuator=] | |
| The [=gamepad=]'s [=vibration actuator=]. |
| following steps: | ||
| </p> | ||
| <ol> | ||
| <li>If |gamepad|'s [=relevant global object=] is not a {{Window}}, |
There was a problem hiding this comment.
Maybe add a note here that this might be different on some browsers... we might need a privacy protection here.
3 participants
Closes #???
The following tasks have been completed:
Implementation commitment:
Preview | Diff