Update getGamepads to include steps for copying gamepads#172
Open
Update getGamepads to include steps for copying gamepads#172
Conversation
marcoscaceres
approved these changes
Dec 12, 2022
Member
There was a problem hiding this comment.
This is an improvement, but I don't think this is exactly right... I think we should use #136 here..
I think what we actually want is:
- The model says there is a conceptual gamepads 🎮🎮🎮 representing real (or conceptual) things.
- When .getGamepads() is called, we go to the model and "snapshot" each conceptual gamepad (i.e., make the lists, copy stuff from the conceptual ones).
- return the result.
Right now, this reads like we are recycling what is normally returned by .getGamepads().
I'm approving, but let's move to using the model.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #???
The following tasks have been completed:
Implementation commitment:
Preview | Diff