Spec liveness of Gamepad and GamepadButton objects (#8)#123
Open
nondebug wants to merge 12 commits intow3c:gh-pagesfrom
Open
Spec liveness of Gamepad and GamepadButton objects (#8)#123nondebug wants to merge 12 commits intow3c:gh-pagesfrom
nondebug wants to merge 12 commits intow3c:gh-pagesfrom
Conversation
marcoscaceres
requested changes
Oct 25, 2019
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
marcoscaceres
requested changes
Nov 8, 2019
Member
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
Couple of issues... the button attribute returning a new object sometimes might be a problem, so we should figure something out there.
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
The following tasks have been completed:
Implementation commitment:
Preview | Diff