[mediaqueries-5] Lift parens to <media-in-parens>#13575
Closed
[mediaqueries-5] Lift parens to <media-in-parens>#13575
Conversation
This change was made to level 4 in 1af56e0 but was never carried over to level 5. This is relied on by the `<if-test>` grammar in css-values-5
Calme1709
added a commit
to Calme1709/ladybird
that referenced
this pull request
Mar 2, 2026
Having this as part of `<media-feature>` seemed to be a spec bug, see w3c/csswg-drafts#13575
Calme1709
added a commit
to Calme1709/ladybird
that referenced
this pull request
Mar 2, 2026
Having this as part of `<media-feature>` seemed to be a spec bug, see w3c/csswg-drafts#13575
Collaborator
|
I already suggested this change two years ago. (So MQ authors might have reasons for not being interested in this change.) |
AtkinsSJ
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Mar 9, 2026
Having this as part of `<media-feature>` seemed to be a spec bug, see w3c/csswg-drafts#13575
Member
|
Nah, we're just bad at keeping on top of PRs. I've merged @cdoublev 's original PR, as it fixes slightly more than this one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was made to level 4 in 1af56e0 but was never carried over to level 5. This is relied on by the
<if-test>grammar in css-values-5