T7557: Updates for Debian Trixie by sarthurdev · Pull Request #4576 · vyos/vyos-1x

sarthurdev · 2025-06-24T19:27:52Z

Change summary

Update tests for nose2 (nose package removed)
Serial session check no longer possible with utmp (utmp removed)
Use Debian update-locale to change time format (localectl setting is unsupported/blocked)
Add e2fsprogs for installer mkfs.ext4
Add systemd units for SysV init files (systemd-sysv-generator deprecated)
Silence verbose dmesg log from console
Migrate and remove SSH DSA keys (unsupported and removed in Trixie)
Resolve container issues by migrating to podman quadlet for container/network unit handling
Add workaround for test_ssh_trusted_user_ca test due to upstream Paramiko bug
Service https/api requires python3-fastapi package
Added workaround for DNS forwading legacy config format

Outstanding issues:

Podman network aardvark-dns does not work, disabled until local or upstream fix found
Migrate DNS forwarding to new YAML config format

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code style update (formatting, renaming)
Refactoring (no functional changes)
Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Smoketests fail spectacularly, this is draft for now.

Checklist:

I have read the CONTRIBUTING document
I have linked this PR to one or more Phabricator Task(s)
I have run the components SMOKETESTS if applicable
My commit headlines contain a valid Task id
My change requires a change to the documentation
I have updated the documentation accordingly

github-actions · 2025-06-24T19:28:03Z

👍
No issues in PR Title / Commit Title

github-actions · 2025-06-26T13:21:06Z

✅ No issues found in unused-imports check.. Please refer the workflow run

github-actions · 2025-07-14T12:41:24Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

github-actions · 2025-08-03T20:47:27Z

CI integration ❌ failed!

Details

CI logs

CLI Smoketests (no interfaces) ❌ failed
CLI Smoketests (interfaces only) ❌ failed
Config tests ❌ failed
RAID1 tests ❌ failed
TPM tests ❌ failed

dmbaturin

I have to admit I got too caught up in the discussion of the Trixie update timeline and overlooked the fact that this PR mixes purely internal changes with feature removals and config syntax changes.

We must create separate tasks and PRs for eventual removal of DSS and DSA support from SSH. We should also add deprecation warnings about those things now (https://vyos.dev/T7705).

dmbaturin · 2025-08-11T10:53:32Z

 RuntimeDirectoryPreserve=yes
 ExecStart=
-ExecStart=/usr/sbin/pdns_recursor --daemon=no --write-pid=no --disable-syslog --log-timestamp=no --config-dir={{ config_dir }}
+ExecStart=/usr/sbin/pdns_recursor --daemon=no --write-pid=no --disable-syslog --log-timestamp=no --config-dir={{ config_dir }} --enable-old-settings


I feel this warrants a comment to explain what the old settings in question are. Or can we change the scripts to make this no longer necessary?

PowerDNS changed the settings format to YAML from legacy config files.

This argument enables our legacy .conf templates to work, pending rewrite to YAML.

dmbaturin · 2025-08-11T10:55:13Z

  python3-netaddr,
  python3-netifaces,
-  python3-nose,
+  python3-nose2,


python3-nose2 exists in Bookworm — can we update these dependencies separately right now?

dmbaturin · 2025-08-11T10:56:36Z

  mokutil,
  shim-signed [amd64],
  sbsigntool [amd64],
+  e2fsprogs,


We could add it right now.

dmbaturin · 2025-08-11T10:57:02Z

 Package: vyos-1x-smoketest
 Architecture: all
 Depends:
+ python3-systemd,


We could add it right now, in a PR to upgrade dependencies.

dmbaturin · 2025-08-11T11:00:59Z

 RE_GETTY_DEVICES = re.compile(r'.+@(.+).service$')

 SD_UNIT_PATH = '/run/systemd/system'
-UTMP_PATH = '/run/utmp'


This certainly deserves a separate task.

dmbaturin · 2025-08-11T11:01:35Z


        # Ensure systemd units are removed
-        units = glob.glob('/run/systemd/system/vyos-container-*')
+        units = glob.glob('/run/containers/systemd/vyos*')


I'm sure this also needs its own task.

dmbaturin · 2025-08-11T11:03:43Z

+# You should have received a copy of the GNU Lesser General Public License
+# along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+# T7557: OpenSSH on Trixie does not support DSS keys


Configuration syntax changes always require separate tasks and PRs and cannot be lumped together with any other changes under any circumstances — we need to track them separately for release notes as incompatible changes so we must take every step to make sure they aren't lost.

Please create a separate task in Phorge for DSS support removal and move this to a separate PR.

dmbaturin · 2025-08-11T11:04:32Z

+# You should have received a copy of the GNU Lesser General Public License
+# along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+# T7557: OpenSSH does not support DSA keys in Debian Trixie


This also must be a separate task and a separate PR.

dmbaturin · 2025-08-21T14:18:46Z

The idea to upgrade to Trixie is on hold now, so I'm closing this PR series — not because they are bad, we'll reopen and merge them when we are ready to upgrade.

github-actions Bot assigned sarthurdev Jun 24, 2025

github-actions Bot added the current label Jun 24, 2025

sarthurdev force-pushed the T7557 branch 3 times, most recently from bedf69a to f813a93 Compare June 25, 2025 11:37

sarthurdev force-pushed the T7557 branch from 0db3588 to 98af77e Compare June 26, 2025 13:35

sever-sever reviewed Jun 26, 2025

View reviewed changes

Comment thread python/vyos/utils/serial.py

sarthurdev force-pushed the T7557 branch 3 times, most recently from dfed132 to d83f98b Compare June 28, 2025 13:34

sarthurdev mentioned this pull request Jun 29, 2025

T7557: Use Debian trixie as build base for container and VyOS image vyos/vyos-build#978

Closed

11 tasks

vyos deleted a comment from github-actions Bot Jun 29, 2025

sarthurdev force-pushed the T7557 branch from d45bb0b to 4c70b24 Compare June 29, 2025 12:41

vyos deleted a comment from github-actions Bot Jun 29, 2025

sarthurdev force-pushed the T7557 branch 2 times, most recently from 6373780 to c053764 Compare June 29, 2025 23:13

vyos deleted a comment from github-actions Bot Jun 30, 2025

sarthurdev marked this pull request as ready for review June 30, 2025 19:48

sarthurdev requested review from c-po, dmbaturin, jestabro and sever-sever June 30, 2025 19:49

sarthurdev force-pushed the T7557 branch from 52e7a8f to 8b1d6a7 Compare July 14, 2025 12:41

sarthurdev force-pushed the T7557 branch 3 times, most recently from 0dba954 to 292bb92 Compare July 31, 2025 14:57

sarthurdev added 15 commits August 3, 2025 22:02

T7557: python3-nose -> python3-nose2

c5d9877

T7557: Check serial sessions without utmp

3f4be8e

T7557: Use update-locale to change time format

110be2f

T7557: Add e2fsprogs package for installer

c3ff111

T7557: Update stunnel4 systemd unit

59665ec

T7557: Add systemd units for sysv init scripts

657e552

T7557: Set dmesg tty loglevel to warning

b1542a2

T7557: DSA keys not supported in Trixie

f84a046

T7557: Use systemd quadlet for containers

5dab884

T7557: Fix dns-forwarding, pending yaml re-write

c67ae6c

T7557: Add python systemd module for interface smoketests

0fc8fb2

T7557: Use systemd check for salt-minion process

056958f

T7557: Fix netplug hook for interface flapping

4ee0bce

T7557: Fix bridge bpdu/root guard test

8693365

T7557: Prevent zombie process crashing pppoe smoketest

ede2bf3

sarthurdev force-pushed the T7557 branch from 292bb92 to ede2bf3 Compare August 3, 2025 20:02

sarthurdev added 2 commits August 3, 2025 22:46

T7557: Fix pylint detected errors

a8931b1

T7557: Update locked user check without spwd module

c6bef37

sarthurdev force-pushed the T7557 branch from 84f6b8a to c6bef37 Compare August 3, 2025 20:46

dmbaturin requested changes Aug 11, 2025

View reviewed changes

dmbaturin closed this Aug 21, 2025

Conversation

sarthurdev commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change summary

Types of changes

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

Uh oh!

github-actions Bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2025

Details

Uh oh!

dmbaturin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmbaturin commented Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

sarthurdev commented Jun 24, 2025 •

edited

Loading

github-actions Bot commented Jun 24, 2025 •

edited

Loading

github-actions Bot commented Jun 26, 2025 •

edited

Loading

github-actions Bot commented Jul 14, 2025 •

edited

Loading