Open
Conversation
Closed
andersk
force-pushed
the
upgrade
branch
5 times, most recently
from
95195ff to
822309c
Compare
Many of our dependencies (svgicons2svgfont, ttf2woff2, url-join, file-type, read-chunk) are now ESM-only, so we need to convert to ESM as well. This is a breaking change, but it’s the only option going forward. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
Hello there! I'm using this awesome package webfonts-loader which depends on https://github.com/vusion I've encountered an issue with I noticed that this PR seems to fix this problem. Could you please let me know if this fix will be officially released soon? Thanks in advance :) |
It’s unclear why this project has both package-lock.json and yarn.lock, but I have updated both. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
@andersk since this fork seems abandoned can you push your changes as a new npm package? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of our dependencies (svgicons2svgfont, ttf2woff2, url-join, file-type, read-chunk) are now ESM-only, so we need to convert to ESM as well. This is a breaking change, but it’s the only option going forward.
It’s unclear why this project has both package-lock.json and yarn.lock, but I have updated both. Ideally we should pick one and delete the other; otherwise npm and yarn will fight with each other and repeatedly add useless yarn.lock churn to the Git history.