Open
Conversation
Author
|
@delenamalan: I can't add you directly as a reviewer, but you may want to have a look at this too? |
Contributor
|
Awesome! 💯 Don't you want to create a PR on the |
Author
|
@delenamalan: That's an option! My instinct is to let the code settle into use here a bit first, before submitting upstream, to let rough edges in the design / interface rough be worked out. (It's a lot harder to change interface once it's an upstream public API.) |
These implement common code for checking cell, row, and column constraints.
Also format with black, while here.
These implement common code for checking cell, row, and column constraints.
a1fad68 to
5f5f661
Compare
Author
|
(Rebased and updated.) |
deanmalan
approved these changes
May 6, 2019
Author
|
@delenamalan: Awesome, thanks. :) @jbothma: Do you want to look over this too, or happy to merge? |
Contributor
|
Oh have you already brought it up to date with master? nice! I'll have a look ASAP. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows PR #11: I ended up hacking on this at the Codebridge community evening last night. 🙂️
This:
(This also applies
isortandblackto the touched code, in the hope of standardising in that direction.)