fix(VTextField): forward title attribute to root element#22779
Closed
hellozzm wants to merge 1 commit intovuetifyjs:masterfrom
Closed
fix(VTextField): forward title attribute to root element#22779hellozzm wants to merge 1 commit intovuetifyjs:masterfrom
hellozzm wants to merge 1 commit intovuetifyjs:masterfrom
Conversation
The title HTML attribute was being filtered into inputAttrs and applied to the hidden input element in VSelect, making it invisible to users. This fix adds title to the rootAttrs list in filterInputAttrs so it is applied to the root element where it can function as a tooltip. Fixes vuetifyjs#22730
Contributor
|
You did not even bother to look at already opened PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
titleHTML attribute was being routed to the<input>element viainputAttrsinfilterInputAttrs. For VSelect, the actual<input>is hidden, so the title tooltip never appears on hover.This fix adds
titleto therootAttrspick list infilterInputAttrs, so it gets applied to the root element where it can function as a native browser tooltip.Playground Markup
Testing
Fixes #22730