Skip to content

Aria label#1131

Open
isabellafagioli wants to merge 3 commits intomasterfrom
aria-label
Open

Aria label#1131
isabellafagioli wants to merge 3 commits intomasterfrom
aria-label

Conversation

@isabellafagioli
Copy link
Copy Markdown

@isabellafagioli isabellafagioli commented Feb 26, 2025 •
edited
Loading

What problem is this solving?

ADA compliance for missing aria-label

How to test it?

With the theme linked see if the Container has an aria-label

Workspace

@isabellafagioli isabellafagioli requested a review from a team as a code owner February 26, 2025 16:49
@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd Bot commented Feb 26, 2025 •
edited by isabellafagioli
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link
Copy Markdown

vtex-io-docs-bot Bot commented Feb 26, 2025 •
edited by isabellafagioli
Loading

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2025

Fails
🚫

Please remove the line ## [3.176.2] - 2025-02-03 from CHANGELOG.md
This will be automatically added once this PR is merged.
Warnings
⚠️

👀 The size of this pull request seems relatively large (>420 modifications). Consider splitting it into smaller pull requests to help make reviews easier and faster.

Generated by 🚫 dangerJS against 10fd54c

@isabellafagioli isabellafagioli requested a review from a team as a code owner March 7, 2025 17:20
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 7, 2025
View reviewed changes
Comment thread react/__mocks__/vtex.css-handles.js
return false
}
if (/[^A-z0-9-]/.test(modifier)) {

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

To fix the problem, we need to correct the regular expression range to match only the intended characters. Specifically, we should replace the range A-z with A-Za-z to ensure that only uppercase and lowercase letters are matched. This change will prevent unintended characters from being included in the match.

  • Update the regular expression on line 58 to use the correct range A-Za-z.
  • No additional methods, imports, or definitions are needed to implement this change.
Suggested changeset 1
react/__mocks__/vtex.css-handles.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/react/__mocks__/vtex.css-handles.js b/react/__mocks__/vtex.css-handles.js
--- a/react/__mocks__/vtex.css-handles.js
+++ b/react/__mocks__/vtex.css-handles.js
@@ -57,3 +57,3 @@
 
-  if (/[^A-z0-9-]/.test(modifier)) {
+  if (/[^A-Za-z0-9-]/.test(modifier)) {
     console.error(
EOF
@@ -57,3 +57,3 @@

if (/[^A-z0-9-]/.test(modifier)) {
if (/[^A-Za-z0-9-]/.test(modifier)) {
console.error(
Copilot is powered by AI and may make mistakes. Always verify output.
Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment thread react/components/Newsletter/index.js
import SUBSCRIBE_NEWSLETTER from './mutations/subscribeNewsletter.graphql'

const EMAIL_REGEX =
/^[A-z0-9+_-]+(?:\.[A-z0-9+_-]+)*@(?:[A-z0-9](?:[A-z0-9-]*[A-z0-9])?\.)+[A-z0-9](?:[A-z0-9-]*[A-z0-9])?$/

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsseixaso vsseixaso Awaiting requested review from vsseixaso vsseixaso is a code owner automatically assigned from vtex-apps/store-framework-devs

@RodrigoTadeuF RodrigoTadeuF Awaiting requested review from RodrigoTadeuF RodrigoTadeuF is a code owner automatically assigned from vtex-apps/store-framework-devs

@leo-prange-vtex leo-prange-vtex Awaiting requested review from leo-prange-vtex leo-prange-vtex is a code owner automatically assigned from vtex-apps/store-framework-devs

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isabellafagioli @github-advanced-security @AnandhanMahi