Fix list count on render #179
Conversation
nicholas-maestrello
requested review from
ArthurTriis1,
ataideverton,
brunohasouza and
rodrigo-tavares
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
react/components/ReviewBlock.tsx
Outdated
|
|
||
| return <div>{refidLoading ? '-' : count}</div> | ||
| cellRenderer: ({ rowData }: any) => { | ||
| return <div> {refidLoading ? '-' : rowData.index + 1}</div> |
There was a problem hiding this comment.
Vale extrair para uma variável externa.
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What does this PR do?
Fixes a bug in the quickorder upload review table where line numbers were displaying incorrectly due to React re-renders incrementing a local counter variable multiple times.
How to test it?
/quickorderpageDescribe alternatives you've considered, if any.
useRefto maintain the counter state - rejected as unnecessarily complexrowData.lineinstead ofrowData.index- both work, butindexis more consistently maintained throughout the component