Merged
Conversation
…osing inside lambdas, or unifying them in an unsound way
… indices in literals
MichaelRawson
approved these changes
Mar 24, 2026
…on the fly breaks with quantified polymorphic vars
25b8a5c to
adec20b
Compare
… tests to see how it works
c315ca8 to
ffd11b8
Compare
| if (transformed.isVar() || !exploreSubterms(ts, transformed)) { | ||
| return transformed; | ||
| } | ||
| return TermList(transform(transformed.term())); |
Collaborator
There was a problem hiding this comment.
Doesn't this change affect plain first order paths through the code?
Contributor
Author
There was a problem hiding this comment.
It is called from first-order paths, too, but the default implementation kicks in, which just checks ts == transformed, so the extra condition is always true for those implementations.
quickbeam123
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following improvements towards HOL in master:
Regression over FOL TPTP with Discount/Otter actually shows 3, resp. 5 problems gained (I will check these), while regression over HOL TPTP with Discount/Otter shows ~1000 problems gained over master (and <100 lost due to divergence in saturation or because of the unsoundness caused by the unbound DB indices). We also crash now on a few hundred problems. I hope this chaos will all go away once more features and fixes get merged.