Jackson3 was released. That would require some work if we want to sup… by mihxil · Pull Request #72 · vpro/vpro-shared

mihxil · 2025-11-25T15:22:42Z

…port it. This branch.

Copilot

Copilot reviewed 63 out of 63 changed files in this pull request and generated 19 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T16:03:57Z

vpro-shared-jackson3/src/main/java/nl/vpro/jackson3/BackwardsCompatibleJsonEnum.java

+                try {
+                    return Enum.valueOf(enumClass, jp.getValueAsString().toUpperCase());
+                } catch (IllegalArgumentException iaeu) {
+                    if (ctxt.getConfig().hasDeserializationFeatures(EnumFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL. getMask())) {


There is a space before the dot in getMask(). The method call should be EnumFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL.getMask() without the space before the period.

Suggested change

if (ctxt.getConfig().hasDeserializationFeatures(EnumFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL. getMask())) {

if (ctxt.getConfig().hasDeserializationFeatures(EnumFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL.getMask())) {

Copilot · 2026-01-09T16:03:57Z

vpro-shared-jackson2/src/test/java/nl/vpro/jackson2/JsonArrayIteratorTest.java

+                    "mid": "POMS_NCRV_1138990",
+                    "deleted": true
+                }
+                }


The closing bracket for the array is missing on this line. There should be a closing bracket ] after line 42.

Suggested change

}

]

Copilot · 2026-01-09T16:03:58Z

vpro-shared-jackson3/src/main/java/nl/vpro/jackson3/JsonArrayIterator.java

+     *                        of the 'complete' result can be in the beginning of the json in this field.
+     * @param objectMapper    Default the objectMapper {@link Jackson3Mapper#LENIENT} will be used (in
+     *                        conjunction with <code>valueClass</code>, but you may specify another one
+     * @param logger          Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.


The reference in this documentation comment still refers to Jackson2Mapper but should be updated to Jackson3Mapper since this is in the jackson3 package.

Suggested change

* @param logger Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.

* @param logger Default this is logging to nl.vpro.jackson3.JsonArrayIterator, but you may override that.

Copilot · 2026-01-09T16:03:58Z

vpro-shared-jackson3/src/test/java/nl/vpro/jackson3/IterableJsonTest.java

+public class IterableJsonTest {
+
+    @XmlAccessorType(XmlAccessType.FIELD)
+    public static class A {


Class A overrides equals but not hashCode.

Copilot · 2026-01-09T16:03:59Z

vpro-shared-jackson3/src/main/java/nl/vpro/jackson3/DurationToSecondsFloatTimestamp.java

+        public Duration deserialize(JsonParser jp, DeserializationContext ctxt) {
+            return Duration.ofMillis((long) (Float.parseFloat(jp.getValueAsString()) * 1000));


Potential uncaught 'java.lang.NumberFormatException'.

Suggested change

public Duration deserialize(JsonParser jp, DeserializationContext ctxt) {

return Duration.ofMillis((long) (Float.parseFloat(jp.getValueAsString()) * 1000));

public Duration deserialize(JsonParser jp, DeserializationContext ctxt) throws JacksonException {

String text = jp.getValueAsString();

if (text == null) {

return null;

}

try {

float seconds = Float.parseFloat(text);

return Duration.ofMillis((long) (seconds * 1000));

} catch (NumberFormatException e) {

ctxt.reportInputMismatch(Duration.class,

"Cannot deserialize Duration from value (%s) as floating-point seconds", text);

// reportInputMismatch always throws, but return is required for compilation

return null;

}

Copilot · 2026-01-09T16:04:02Z

vpro-shared-jackson3/src/main/java/nl/vpro/jackson3/JsonArrayIterator.java

+     *                        of the 'complete' result can be in the beginning of the json in this field.
+     * @param objectMapper    Default the objectMapper {@link Jackson3Mapper#LENIENT} will be used (in
+     *                        conjunction with <code>valueClass</code>, but you may specify another one
+     * @param logger          Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.


@param tag "logger" does not match any actual parameter of method "toString()".
@param tag "logger" does not match any actual parameter of method "build()".
@param tag "logger" does not match any actual parameter of method "eventListener()".
@param tag "logger" does not match any actual parameter of method "skipNulls()".
@param tag "logger" does not match any actual parameter of method "objectMapper()".
@param tag "logger" does not match any actual parameter of method "totalSizeField()".
@param tag "logger" does not match any actual parameter of method "sizeField()".
@param tag "logger" does not match any actual parameter of method "callback()".
@param tag "logger" does not match any actual parameter of method "valueClass()".
@param tag "logger" does not match any actual parameter of method "valueCreator()".
@param tag "logger" does not match any actual parameter of method "inputStream()".
@param tag "logger" does not match any actual parameter of method "_builder()".
@param tag "logger" does not match any actual parameter of constructor "Builder()".

Suggested change

* @param logger Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.

* Logger: Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.

Copilot · 2026-01-09T16:04:03Z

vpro-shared-jackson3/src/main/java/nl/vpro/jackson3/JsonArrayIterator.java

+     * @param objectMapper    Default the objectMapper {@link Jackson3Mapper#LENIENT} will be used (in
+     *                        conjunction with <code>valueClass</code>, but you may specify another one
+     * @param logger          Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.
+     * @param skipNulls       Whether to skip nulls in the array. Default true.


@param tag "skipNulls" does not match any actual parameter of method "toString()".
@param tag "skipNulls" does not match any actual parameter of method "build()".
@param tag "skipNulls" does not match any actual parameter of method "eventListener()".
@param tag "skipNulls" does not match any actual parameter of method "logger()".
@param tag "skipNulls" does not match any actual parameter of method "objectMapper()".
@param tag "skipNulls" does not match any actual parameter of method "totalSizeField()".
@param tag "skipNulls" does not match any actual parameter of method "sizeField()".
@param tag "skipNulls" does not match any actual parameter of method "callback()".
@param tag "skipNulls" does not match any actual parameter of method "valueClass()".
@param tag "skipNulls" does not match any actual parameter of method "valueCreator()".
@param tag "skipNulls" does not match any actual parameter of method "inputStream()".
@param tag "skipNulls" does not match any actual parameter of method "_builder()".
@param tag "skipNulls" does not match any actual parameter of constructor "Builder()".

Suggested change

* @param skipNulls Whether to skip nulls in the array. Default true.

* skipNulls: Whether to skip nulls in the array. Default true.

Copilot · 2026-01-09T16:04:03Z

vpro-shared-jackson3/src/main/java/nl/vpro/jackson3/JsonArrayIterator.java

+     *                        conjunction with <code>valueClass</code>, but you may specify another one
+     * @param logger          Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.
+     * @param skipNulls       Whether to skip nulls in the array. Default true.
+     * @param eventListener   A listener for events that happen during parsing and iteration of the array. See {@link Event} and extension classes.


@param tag "eventListener" does not match any actual parameter of method "toString()".
@param tag "eventListener" does not match any actual parameter of method "build()".
@param tag "eventListener" does not match any actual parameter of method "skipNulls()".
@param tag "eventListener" does not match any actual parameter of method "logger()".
@param tag "eventListener" does not match any actual parameter of method "objectMapper()".
@param tag "eventListener" does not match any actual parameter of method "totalSizeField()".
@param tag "eventListener" does not match any actual parameter of method "sizeField()".
@param tag "eventListener" does not match any actual parameter of method "callback()".
@param tag "eventListener" does not match any actual parameter of method "valueClass()".
@param tag "eventListener" does not match any actual parameter of method "valueCreator()".
@param tag "eventListener" does not match any actual parameter of method "inputStream()".
@param tag "eventListener" does not match any actual parameter of method "_builder()".
@param tag "eventListener" does not match any actual parameter of constructor "Builder()".

Suggested change

* @param eventListener A listener for events that happen during parsing and iteration of the array. See {@link Event} and extension classes.

* A listener for events that happen during parsing and iteration of the array. See {@link Event} and extension classes.

Copilot · 2026-01-09T16:04:03Z

vpro-shared-jackson3/src/test/java/nl/vpro/jackson3/IterableJsonTest.java

+        public A(String x) {
+            this.x = x;
+        }
+        public boolean equals(Object other){


This method overrides Object.equals; it is advisable to add an Override annotation.

Copilot · 2026-01-09T16:04:04Z

vpro-shared-test/src/main/java/nl/vpro/test/util/jackson3/Jackson3TestUtil.java

+            }
+            return assertThat(rounded);
+        }
+        public A get() {


This method overrides Supplier.get; it is advisable to add an Override annotation.

Michiel Meeuwissen and others added 20 commits November 25, 2025 16:22

Jackson3 was released. That would require some work if we want to sup…

aa4b425

…port it. This branch.

Fixing all kind of changes because of jackson2 -> 3

59bfbe3

More jackson2 -> 3

1973b4b

added dep -jackson3

5d377c6

More jackson3 support work.

23cc0fb

Made it compile.

72ccf69

Made it compile.

a8e6b65

Merge branch 'main' into jackson3-support

ec30019

Try with snapshot.

a54ca62

Made it compile.

6185c27

Small new feature, that makes log4j2-test superflous.

f4f6b43

Trying to fix test cases.

0fa9357

Trying to fix test cases.

e0860bc

Trying to fix test cases.

4b3ad1d

Merged main.

8b423a9

Upped some dependencies.

59d58be

No need to do that for something else.

be848cd

Test case failures.

3fcf537

Fixing test cases.

4a225be

Finally figured it out.

c8f68ec

mihxil marked this pull request as ready for review January 9, 2026 15:56

mihxil requested a review from Copilot January 9, 2026 15:56

Copilot started reviewing on behalf of mihxil January 9, 2026 15:57 View session

mihxil merged commit 4a9ccd6 into main Jan 9, 2026
4 of 5 checks passed

mihxil deleted the jackson3-support branch January 9, 2026 15:58

Copilot AI reviewed Jan 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jackson3 was released. That would require some work if we want to sup…#72

Jackson3 was released. That would require some work if we want to sup…#72
mihxil merged 20 commits intomainfrom
jackson3-support

mihxil commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	if (ctxt.getConfig().hasDeserializationFeatures(EnumFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL. getMask())) {
	if (ctxt.getConfig().hasDeserializationFeatures(EnumFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL.getMask())) {

	* @param logger Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.
	* @param logger Default this is logging to nl.vpro.jackson3.JsonArrayIterator, but you may override that.

		public Duration deserialize(JsonParser jp, DeserializationContext ctxt) {
		return Duration.ofMillis((long) (Float.parseFloat(jp.getValueAsString()) * 1000));

-        public Duration deserialize(JsonParser jp, DeserializationContext ctxt) {
-            return Duration.ofMillis((long) (Float.parseFloat(jp.getValueAsString()) * 1000));
+        public Duration deserialize(JsonParser jp, DeserializationContext ctxt) throws JacksonException {
+            String text = jp.getValueAsString();
+            if (text == null) {
+                return null;
+            }
+            try {
+                float seconds = Float.parseFloat(text);
+                return Duration.ofMillis((long) (seconds * 1000));
+            } catch (NumberFormatException e) {
+                ctxt.reportInputMismatch(Duration.class,
+                    "Cannot deserialize Duration from value (%s) as floating-point seconds", text);
+                // reportInputMismatch always throws, but return is required for compilation
+                return null;
+            }

	* @param logger Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.
	* Logger: Default this is logging to nl.vpro.jackson2.JsonArrayIterator, but you may override that.

	* @param skipNulls Whether to skip nulls in the array. Default true.
	* skipNulls: Whether to skip nulls in the array. Default true.

	* @param eventListener A listener for events that happen during parsing and iteration of the array. See {@link Event} and extension classes.
	* A listener for events that happen during parsing and iteration of the array. See {@link Event} and extension classes.

Conversation

mihxil commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant