Skip to content

Done module-bash#3

Open
alinetskyi wants to merge 1 commit into
vpetrusenko:masterfrom
alinetskyi:finish
Open

Done module-bash#3
alinetskyi wants to merge 1 commit into
vpetrusenko:masterfrom
alinetskyi:finish

Conversation

@alinetskyi
Copy link
Copy Markdown

No description provided.

Comment thread ex05/ex05.sh
esac
echo "Error.."
exit 1

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two flags input test not passed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this one too

Comment thread ex01/hello_world.sh
else
echo "Hello, $1!"
fi

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Comment thread ex02/ex02.sh
else
echo the searched PATH is unexisting
fi
done
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 existing paths 2 existing FILES tests are failed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outputs are identical, though don't need to do anything

Comment thread ex03/ex03.sh
else
exit 1
fi

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Comment thread ex04/ex04.sh
basename $files
grep -n $pattern $files | cut -f1 -d":"
exit 0
fi
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No args and Without first arg tests are failed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is wrong, need to update!!

Comment thread ex06/ex06.sh

}

map ${@}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Comment thread ex07/ex07.sh
else
head -$1 resourses/surnames.txt | grep -v 'Q-Chem' | sed 's/-//;s/.$//'
exit 0
fi
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test on 0 lines returns error and Test on 2 lines return empty string are failed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed tests and ex07.sh

Comment thread ex09/ex09.sh
grep '^[a-zA-Z0-9]\+@[a-zA-Z0-9]\+\.[a-z]\{2,\}' $2
;;

esac
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Comment thread ex10/ex10.sh
echo $(awk 'END{print NR}' $1) $1
exit 0
fi
exit 1
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with directory and with 2 files tests are failed

Comment thread ex08/ex08.sh
arr[$i]=$(grep -o $i $1 | wc -l)
result+=' '${arr[$i]}' '${nums[$i]}
done
echo $result
Copy link
Copy Markdown
Owner

@vpetrusenko vpetrusenko Jun 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this one too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants