Release 3.5.0#224
Conversation
|
|
||
| **Merged pull requests:** | ||
|
|
||
| - Migrate static data from hiera to init.pp [\#221](https://github.com/voxpupuli/puppet-systemd/pull/221) ([bastelfreak](https://github.com/bastelfreak)) |
There was a problem hiding this comment.
I'm starting to wake up, but we should consider how we classify this. I think technically this can be breaking for some users. To verify this: previously you could do lookup('systemd::$VAR') even if the module wasn't included from other modules. Now you can't. This is probably not used a lot, but it can break some use cases. That's why I think puppetlabs/puppet-strings#273 would be a better long term solution, but I don't have time to finish it.
There was a problem hiding this comment.
yes, the puppet-strings PR would be the better approach, I also have that on my todo list since years but no time/not enough knowledge. Do you think we should here do a major release instead?
There was a problem hiding this comment.
I'd like to avoid that, but we should keep it in mind.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues