Split generic and specific code #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Apr 22, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Overall this makes sense. I like how you're starting to separate the workflow from low level implementation.
neomilium
force-pushed
the
split_generic_n_specific_code
branch
from
86e291c to
797360e
Compare
This method replaces the old `ModuleSync::module_file`.
neomilium
force-pushed
the
split_generic_n_specific_code
branch
from
797360e to
38efd68
Compare
Contributor
Author
|
@ekohl This PR is ready to merge IMHO, could you have a look? Thanks |
neomilium
force-pushed
the
split_generic_n_specific_code
branch
from
38efd68 to
4e9f330
Compare
Contributor
Author
|
@ekohl Thats the moment to push the big green button ;-) |
ekohl
approved these changes
Apr 23, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I like I don't have to highlight every case of a pattern. You understand that. I've seen it different in some reviews :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers the first step to turn
msyncinto a more generic tool by splittingPuppetModuleclass intoSourceCodeandPuppetModuleclasses.PS: This PR is a part of #206.