Skip to content

Conversation

@neomilium
Copy link
Contributor

ATM, this PR drops the IRC notification feature.

Tell me if you still want it.

@neomilium
Copy link
Contributor Author

Converting to draft and waiting on PR #202 to be merged, as checks failed for an unknown reason on top of master but runs well on top of improve-tests.

opus-codium#1

@neomilium neomilium marked this pull request as draft December 22, 2020 12:27
@neomilium neomilium marked this pull request as ready for review December 22, 2020 12:28
@neomilium neomilium marked this pull request as draft December 22, 2020 12:28
@neomilium neomilium marked this pull request as ready for review January 18, 2021 20:33
@neomilium
Copy link
Contributor Author

Before merging this PR, maintainers need to add secret keys for releasing process (i.e. in .github/workflows/release.yml).

Remind: The IRC notification feature is dropped.

Please consider this contribution as a base, not a fully tested code, multiple reviews appreciated.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the branch to upstream which triggers the tests.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 92d6eeb into voxpupuli:master Apr 21, 2021
@neomilium neomilium deleted the switch-to-gha branch April 21, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants