Minor modernization and cosmetic fix #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the work on #199, I found few minor things that can be improve right now without waiting the end on the work.
On the way, I already provided #200 and now:
I bump the target ruby version of
rubocopto 2.4 (the last supported byrubocop0.50.0) in order to allow squiggly heredoc syntax.Please note I want to provide more further patches to support a recent
rubocopversion, but it implies massive changes, so I choose to make one small step first and keep changes in #199 comprehensive.This PR also contains a minor cosmetic change on CLI help, where some defaults where shown twice.