Implement support for installing staging packages#95
Merged
bastelfreak merged 1 commit intov4from Apr 2, 2026
Merged
Conversation
49880cf to
cac7c71
Compare
nmburgan
reviewed
Apr 1, 2026
nmburgan
approved these changes
Apr 1, 2026
ekohl
reviewed
Apr 22, 2026
| - name: Setup Test Matrix | ||
| id: get-outputs | ||
| run: bundle exec metadata2gha --domain ${{ inputs.domain }} --beaker-facter "${{ inputs.beaker_facter }}" --beaker-hosts "${{ inputs.beaker_hosts }}" | ||
| run: bundle exec metadata2gha --domain ${{ inputs.domain }} --beaker-facter "${{ inputs.beaker_facter }}" --beaker-hosts "${{ inputs.beaker_hosts }}" --collection "${{ inputs.beaker_collection }}" |
Member
There was a problem hiding this comment.
This broke our CI because we're still using puppet_metadata 5.x. theforeman/puppet-pulpcore#400 (comment). In https://github.com/voxpupuli/gha-puppet#gemfile-integration-examples we say 3.2 should still work. If that's not true, I'd vote for making that a new major version (v5?).
A more compatible solution would be to only add --collection if it's specified. May be uglier, but also requires less work for users of the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
This enhances our GitHub workflows. Puppet modules with acceptance tests will now have a trigger to manually run them. And users can configure a specific collection that shall be tested, e.g. openvox7, openvox8 or staging. For staging, you can provide a build version. This will be fetched from https://artifacts.voxpupuli.org/openvox-agent/.
The workflow can be triggered via API. This allows us to test new openvox-agent builds on 125 modules \o/ :tada: