Skip to content

cfg: respect VOUCH_LOGLEVEL when no config file value is set #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cfg: respect VOUCH_LOGLEVEL when no config file value is set #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/cfg/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ func (logging) configure() {
}

// then we weren't configured via command line, check the config file
if !viper.IsSet(Branding.LCName + ".logLevel") {
// or the matching env var. envconfig writes to Cfg.LogLevel directly
// instead of going through viper, so viper.IsSet on its own wasn't
// enough to detect that the user had asked for a specific level via
// e.g. VOUCH_LOGLEVEL. See #540.
if !viper.IsSet(Branding.LCName+".logLevel") && os.Getenv(Branding.UCName+"_LOGLEVEL") == "" {
// then we weren't configured via the config file, set the default
Cfg.LogLevel = Logging.DefaultLogLevel.String()
}
Expand Down