Feature/#119 UI Occurrence Map Fine Tune#121
Open
OldMetalmind wants to merge 19 commits intovostpt:developfrom
Open
Feature/#119 UI Occurrence Map Fine Tune#121OldMetalmind wants to merge 19 commits intovostpt:developfrom
OldMetalmind wants to merge 19 commits intovostpt:developfrom
Conversation
The close button wasn't an expected option.
- Changes Icon - Update size - Increase margin
- Icons were switched
An Align widget was wrapping a single Container
The widget was not showing all module data properly
Added new gray color for the 'last updates' color Decrease the small dimention
Change the margins Update widgets to use more Containers instead
Reduces number of widgets and updates spacing
…eature/vostpt#119-UI_occurrence_map_fine_tune
Contributor
|
Next time please put screenshots in the PR :P |
Vanethos
requested changes
Mar 31, 2020
Contributor
Vanethos
left a comment
Vanethos
left a comment
There was a problem hiding this comment.
package intl is causing conflicts, must be reverted tointl: 0.16.0
Also, in HomeBloc there's the following error:
In line 149, the following is present:
: Stream<List<String>>.empty())
but it should be:
: Stream<List<OccurrenceModel>>.empty())
Since you're fine tuning the UI if you could 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies a series of UI improvements accordingly to the Design but also adds new sizes of lettering, blocks, and spacing.
This changes applies to the Map and some to the Bottom bar.