Skip to content

New C++ api #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
myrrc wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

New C++ api #8651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c7567
initial
myrrc Jul 3, 2026
9ec769b
fix
myrrc Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,20 +460,20 @@ jobs:
sccache: s3
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: ./.github/actions/setup-prebuild
- name: Prepare FFI library
run: |
cargo build --profile ci -p vortex-ffi
- name: Build and run C++ unit tests
run: |
mkdir -p vortex-cxx/build
cmake -S vortex-cxx -B vortex-cxx/build -DVORTEX_ENABLE_TESTING=ON -DVORTEX_ENABLE_ASAN=ON
cmake -S vortex-cxx -B vortex-cxx/build -DBUILD_TESTS=ON -DSANITIZER=asan -DRUST_BUILD_PROFILE=ci
cmake --build vortex-cxx/build --parallel $(nproc)
ctest --test-dir vortex-cxx/build -j $(nproc) -V
./vortex-cxx/build/vortex_cxx_test
- name: Build and run the example in release mode
run: |
cmake -S vortex-cxx/examples -B vortex-cxx/examples/build -DCMAKE_BUILD_TYPE=Release
cmake -S vortex-cxx -B vortex-cxx/examples/build -DBUILD_EXAMPLES=1 -DCMAKE_BUILD_TYPE=Release -DRUST_BUILD_PROFILE=ci
cmake --build vortex-cxx/examples/build --parallel $(nproc)
vortex-cxx/examples/build/hello-vortex vortex-cxx/examples/goldenfiles/example.vortex
- uses: ./.github/actions/check-rebuild
with:
command: "cargo build --profile ci --locked -p vortex-cxx --lib"
vortex-cxx/examples/build/examples/hello-vortex

sqllogic-test:
name: "SQL logic tests"
Expand Down
118 changes: 0 additions & 118 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ members = [
"vortex-cuda/gpu-scan-cli",
"vortex-cuda/macros",
"vortex-cuda/nvcomp",
"vortex-cxx",
"vortex-ffi",
"fuzz",
"vortex-jni",
Expand Down
6 changes: 6 additions & 0 deletions vortex-cxx/.clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright the Vortex contributors
NamespaceIndentation: None
BasedOnStyle: Google
IndentWidth: 4
AccessModifierOffset: -4
7 changes: 3 additions & 4 deletions vortex-cxx/.clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright the Vortex contributors
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright the Vortex contributors

Checks: |
-*,
Expand Down Expand Up @@ -43,7 +43,7 @@ Checks: |
-bugprone-unused-local-non-trivial-variable,
-bugprone-empty-catch,
WarningsAsErrors: '*'
HeaderFilterRegex: '(cpp|examples)/.*\.(cpp|hpp)$'
HeaderFilterRegex: '(examples)/.*\.(cpp|hpp)$'
FormatStyle: none
CheckOptions:
- key: readability-identifier-naming.ClassCase
Expand Down Expand Up @@ -90,4 +90,3 @@ CheckOptions:
value: lower_case
- key: cppcoreguidelines-rvalue-reference-param-not-moved.IgnoreUnnamedParams
value: true

Loading
Loading