Fix vortex-jni local path handling, centralise logic in vortex-file#8650
Conversation
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
a2cfeab to
ecc9af6
Compare
ecc9af6 to
35ad5bf
Compare
Existing logic was duplicated between jni and duckdb with slight differences. JNI logic didn't always handle local paths. Signed-off-by: "robert" <robert@spiraldb.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
35ad5bf to
79e94b4
Compare
… SQL Prompted by discussion #8648, document how to get Vortex into Spark and query it from Spark SQL: - Add a README to java/vortex-spark with quick-start instructions for spark-shell/spark-submit/pyspark, the DataFrame API, and Spark SQL (CREATE TEMPORARY VIEW / CREATE TABLE ... USING vortex LOCATION). - Rework docs/user-guide/spark.md: correct the Maven coordinates to the Scala-suffixed artifacts (vortex-spark_2.12 for Spark 3.5.x, vortex-spark_2.13 for Spark 4.x), document that the self-contained "all" classifier JAR is required (the thin JAR fails with NoClassDefFoundError on relocated classes, so --packages alone does not work), document accepted path forms (bare local paths work since #8650; releases up to 0.76.0 require URL-form paths), and add a Spark SQL section. - Point the root README Maven badge at vortex-spark_2.13; the old unsuffixed artifact stopped publishing at 0.65.0. - Link the new README from java/README.md. The documented examples were verified against the published dev.vortex:vortex-spark_2.13:0.76.0-all JAR with PySpark 4.1.2: DataFrame read/write, CREATE TEMPORARY VIEW ... USING vortex, CREATE TABLE ... USING vortex LOCATION + INSERT + SELECT, and CTAS with LOCATION all pass; managed tables (no LOCATION) and direct file queries (FROM vortex.`path`) fail and are called out as unsupported. Bare local paths are covered by the connector test added in #8650. Signed-off-by: Robert Kruszewski <robert@spiraldb.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LM9s8M99nQHdwhkrba35PU
Existing logic was duplicated between jni and duckdb with slight
differences. JNI logic didn't always handle local paths.