Skip to content

bump parquet to v58 for lance #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
myrrc wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

bump parquet to v58 for lance #7917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 11 additions & 52 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ async-fs = "2.2.0"
async-lock = "3.4"
async-stream = "0.3.6"
async-trait = "0.1.89"
base16ct = "1.0.0"
bigdecimal = "0.4.8"
bindgen = "0.72.0"
bit-vec = "0.9.0"
Expand All @@ -120,7 +119,6 @@ cargo_metadata = "0.23.1"
cbindgen = "0.29.0"
cc = "1.2"
cfg-if = "1.0.1"
chrono = "0.4.42"
clap = "4.5"
criterion = "0.8"
crossterm = "0.29"
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/lance-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ lance = { version = "4", default-features = false }
lance-encoding = { version = "4" }

anyhow = { workspace = true }
arrow-cast = { version = "57" }
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That version was separate because lance is slow to upgrade. Just change it to 58

Copy link
Copy Markdown
Contributor

@AdamGS AdamGS May 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to match whatever lance is using, I don't think you can just bump it. What's the motivation here?

arrow-cast = { workspace = true }
async-trait = { workspace = true }
clap = { workspace = true, features = ["derive"] }
futures = { workspace = true }
parquet = { version = "57" }
parquet = { workspace = true }
tempfile = { workspace = true }
tokio = { workspace = true, features = ["full"] }
tracing = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion encodings/parquet-variant/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ workspace = true
arrow-array = { workspace = true }
arrow-buffer = { workspace = true }
arrow-schema = { workspace = true }
chrono = { workspace = true }
chrono = { version = "0.4", default-features = false }
parquet-variant = { workspace = true }
parquet-variant-compute = { workspace = true }
prost = { workspace = true }
Expand Down
1 change: 0 additions & 1 deletion vortex-test/compat-gen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ tokio = { workspace = true, features = ["full"] }
reqwest = { workspace = true }

# CLI + serialization
base16ct = { workspace = true }
clap = { workspace = true, features = ["derive"] }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
Expand Down
6 changes: 4 additions & 2 deletions vortex-test/compat-gen/src/generate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

use std::path::Path;

use base16ct::HexDisplay;
use serde::Serialize;
use sha2::Digest;
use sha2::Sha256;
Expand Down Expand Up @@ -51,7 +50,10 @@ pub fn write_fixtures(output_dir: &Path, exclude: &[String]) -> VortexResult<Vec
let path = output_dir.join(&entry.name);
let file_bytes = std::fs::read(&path)
.map_err(|e| vortex_err!("failed to read back {}: {e}", path.display()))?;
let sha256 = format!("{:x}", HexDisplay(&Sha256::digest(&file_bytes)));
let sha256: String = Sha256::digest(&file_bytes)
.iter()
.map(|b| format!("{b:02x}"))
.collect();
eprintln!(" wrote {}", entry.name);
infos.push(FixtureInfo {
name: entry.name,
Expand Down
Loading