Fix IsSorted return dtype#7914
Merged
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
| | DType::List(..) | ||
| | DType::FixedSizeList(..) | ||
| | DType::Variant(..) => None, | ||
| _ => Some(DType::Bool(Nullability::NonNullable)), |
Contributor
There was a problem hiding this comment.
This should have been written in the negative variant.
Contributor
Author
There was a problem hiding this comment.
I dont understand?
Contributor
There was a problem hiding this comment.
You enumerate the ones that can instead of the ones that can’t
joseph-isaacs
approved these changes
May 13, 2026
Contributor
|
Is sorted on extension dtype needs to call the vtable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is why catch all arms are dangerous!
Also: I made extension type not sortable, I think this is correct? Though it might also break timestamp is sorted, I have no idea.
Testing
How should we test this?