chore:optimize next_coalesced() by tracking removed ids in a HashSet#6353
Open
caicancai wants to merge 1 commit intovortex-data:developfrom
Open
chore:optimize next_coalesced() by tracking removed ids in a HashSet#6353caicancai wants to merge 1 commit intovortex-data:developfrom
caicancai wants to merge 1 commit intovortex-data:developfrom
Conversation
Signed-off-by: cancaicai <2356672992@qq.com>
caicancai
force-pushed
the
perf/io-coalesce-hashset
branch
from
5deafb8 to
3fe1afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR speeds up State::next_coalesced() by avoiding an O(k) linear scan for every candidate when checking whether a request was already marked for removal. Previously, scanning a window of n candidates with k already-marked ids could cost O(n·k) (worst-case O(n²)). We keep the Vec<(offset, id)> for removals, but add a HashSet for O(1) average membership checks, bringing the scan closer to O(n). Coalescing behavior is unchanged.