perf: reuse query embeddings in hierarchical retriever#93
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Feb 9, 2026
Merged
perf: reuse query embeddings in hierarchical retriever#93qin-ctx merged 1 commit intovolcengine:mainfrom
qin-ctx merged 1 commit intovolcengine:mainfrom
Conversation
qin-ctx
reviewed
Feb 9, 2026
|
|
||
| final_metadata_filter = {"op": "and", "conds": filters_to_merge} | ||
|
|
||
| if not await self.storage.collection_exists(collection): |
Collaborator
There was a problem hiding this comment.
内部默认都是 colleciton 是 context,不过这里检验下也没问题
qin-ctx
approved these changes
Feb 9, 2026
Collaborator
|
good job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
N/A
Type of Change
Changes Made
Preserve existing retrieval logic and output ordering.
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have tested this on the following platforms:
Checklist
Additional Notes
This indicates the expected latency/cost improvement from eliminating duplicate embeddings.
———