feat: in chatmem example, add /time and /add_resource command#77
Merged
qin-ctx merged 23 commits intovolcengine:mainfrom Feb 6, 2026
Merged
feat: in chatmem example, add /time and /add_resource command#77qin-ctx merged 23 commits intovolcengine:mainfrom
qin-ctx merged 23 commits intovolcengine:mainfrom
Conversation
Design document for two new chatmem features: - /time command: display performance timing breakdown - /add_resource command: add documents during chat sessions Includes architecture, detailed implementation plan, and UX examples.
- create_client(): initialize OpenViking client - add_resource(): add files/URLs to database with progress - Extracted from add.py for reusability
- Use shared create_client() and add_resource() - Reduces duplication, maintains same CLI behavior - ~80 lines reduced to ~40 lines
- Track search_time, llm_time, total_time with perf_counter - Return timing data in result dict under 'timings' key - No breaking changes to existing API
- Parse /time <question> syntax - Extract question and call ask_question with show_timing=True - Show usage help if no question provided
- Accept show_timing parameter (default False) - Display timing panel with search/LLM/total times - Format times as seconds with 3 decimal places
- Parse /add_resource <path> syntax - Expand user paths (~/ notation) - Use shared resource_manager module - Show spinner during processing - Immediate feedback when complete
Collaborator
Author
|
ZaynJarvis
force-pushed
the
feat/time_and_add
branch
from
e89e85b to
a01af0c
Compare
ZaynJarvis
force-pushed
the
feat/time_and_add
branch
from
a01af0c to
797f57b
Compare
Collaborator
Author
|
chat/ example is removed
|
6 tasks
qin-ctx
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add examples' capability
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)