fix(session): restore messages from completed archives when messages.jsonl is empty#3198
Open
fangtang0206 wants to merge 1 commit into
Open
Conversation
…jsonl is empty When a session is archived (messages.jsonl cleared), get_session_context() was returning empty messages because _get_pending_archive_messages() only reads archives with index > latest_completed_index (pending archives). This adds a fallback in get_session_context() that reads from completed archives when merged_messages is empty, ensuring the session panel shows the full conversation history. Fixes Issue volcengine#1550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a session is archived (messages.jsonl cleared),
get_session_context()returns empty messages because_get_pending_archive_messages()only reads archives with index > latest_completed_index (pending archives).This causes the OV Studio panel to show empty session history for archived sessions.
Fix
Added a fallback in
get_session_context()that reads messages from completed archives whenmerged_messagesis empty, ensuring the session panel shows the full conversation history.Files
openviking/session/session.py: +15 lines inget_session_context()Verification
curlcall to/api/v1/sessions/{id}/contextwith the session API key returns the archived messages correctly.Fixes #1550