fix: fail embedding writes on empty upsert id#3184
Open
qq788538-dotcom wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
TextEmbeddingHandler.on_dequeue()currently records an embedding message as processed even whenVikingVectorIndexBackend.upsert()returns an empty string. The backend uses an empty ID to signal several failed/no-op write paths. Because the handler only logs when the ID is truthy and then unconditionally reports success, reindex can report hundreds of rebuilt records while the vector collection remains empty.Observed against OpenViking Service v0.4.8:
find: 0 resultsFix
Require a non-empty record ID after upsert. An empty ID raises into the existing database error branch, which already:
error_countThis does not change successful write behavior or shutdown handling.
Test plan
Both pass locally on Python 3.11.15.