fix(agent): detect stop tool anywhere in a multi-tool batch#3169
Open
nankingjing wants to merge 1 commit into
Open
fix(agent): detect stop tool anywhere in a multi-tool batch#3169nankingjing wants to merge 1 commit into
nankingjing wants to merge 1 commit into
Conversation
Tools execute in parallel, so tools_used[-1] is not necessarily the stop tool when it was co-called with another tool in the same batch. Check every executed tool with any() to reliably preserve an intentional empty final reply.
Contributor
Author
| Self-reviewed: diff is correct, minimal, and well-tested. No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent loop's stop-tool detection only inspected a single tool in a batch, so when the model emitted several tool calls in one turn and a stop tool was not in the first position, the loop failed to recognize it and did not stop.
Problem
The check tested one entry rather than the whole batch, missing a stop tool anywhere but the checked position.
Fix
Detect a stop tool anywhere in the batch:
so a stop tool in any position terminates the loop as intended.
Test
bot/vikingbot/tests/unit/test_agent/test_stop_tool_preservation.py— covers a stop tool in a non-first batch position triggering stop (3 passed).