refactor: remove unused MaybeString wrapper type#336
Merged
branchseer merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
branchseer
force-pushed
the
remove-maybe-string
branch
from
ea30426 to
5dd365d
Compare
MaybeString existed solely to add bincode Encode/Decode traits to Vec<u8>. With wincode, Vec<u8> already implements SchemaWrite/SchemaRead natively. The type was never referenced outside its own module. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
branchseer
force-pushed
the
remove-maybe-string
branch
from
5dd365d to
666482e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaybeStringnewtype wrapper (crates/vite_task/src/maybe_str.rs)Encode/DecodetoVec<u8>, which wincode supports nativelyTest plan
cargo clippypassescargo test --workspace --exclude fspypasses🤖 Generated with Claude Code