Skip to content

chore: update binding auto gen codes#1366

Closed
fengmk2 wants to merge 1 commit intomainfrom
update-binding-codes
Closed

chore: update binding auto gen codes#1366
fengmk2 wants to merge 1 commit intomainfrom
update-binding-codes

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Apr 12, 2026

No description provided.

@fengmk2 fengmk2 self-assigned this Apr 12, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 12, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit d774964
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69dbc872058a020008fad465

Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 12, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review April 12, 2026 16:29
@fengmk2 fengmk2 requested a review from cpojer April 13, 2026 00:54
Copy link
Copy Markdown
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding so many new exports here?

@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 13, 2026

@Brooooooklyn https://github.com/voidzero-dev/vite-plus/pull/1352/changes#diff-18ae0a0fab29a7db7aded913fd05f30a2c8f6c104fadae86c9d217091709794cR15 I rolled back by commit and found that this was caused by updating to @napi-rs/cli@3.6.1. Is this an expected behavior change?

@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 13, 2026

@Brooooooklyn @cpojer My environment had RELEASE_BUILD=1 set at some point, which is why this change occurred. This change is unnecessary.
Sorry to bother you 😢

@fengmk2 fengmk2 closed this Apr 13, 2026
@fengmk2 fengmk2 deleted the update-binding-codes branch April 13, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants