Merged
Conversation
added 2 commits
February 3, 2026 16:44
- Add us-east-1 provider for ACM (required for CloudFront) - Create ACM certificate with DNS validation when domain_name is set - CloudFront uses ACM cert and domain alias when configured - Output ACM validation records and CloudFront domain for DNS setup
- Remove in-terraform ACM cert creation (was causing DNS validation issues) - Add acm_certificate_arn variable to pass existing cert ARN - Update CI/CD to pass ACM_CERTIFICATE_ARN secret - Simpler: create cert once in AWS, reuse across deploys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.