-
Notifications
You must be signed in to change notification settings - Fork 69
allow alternative udev #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not a fan of this, udev is the default and I don't think we would support any other setup. You can uninstall udevd and drop in your own file if required. |
|
Would agree with duncaen, one point of having these files in a directory instead of being a single file is so you can make these changes on your own system (or with automation) in a safe way. |
|
What you say makes sense. However, one advantage of the small modification I propose is that it kills the device manager at the end of stage 1 (if you do not start the corresponding service with runit, that it is left running currently). I also tested it and it seems to work fine. |
|
I don't see what the problem would be, none of the changes break udev, and they allow for more flexibility. And this benefits both udev and libudev-zero users |
vincele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| _udevd=udevd | ||
| else | ||
| msg_warn "cannot find udevd!" | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume loosing this systemd-specific file name and path is OK (not that I really personally care)
| # The device manager to run during the init process. This is killed once boot | ||
| # is complete for a supervised version to take its place. Valid values are | ||
| # currently 'mdevd' or 'udevd' (default). | ||
| CONFIG_DEV=udevd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the variable name to CONFIG_DEVD, or something like that, as I think the _DEV suffix would imply a device. But that's bikeshedding, feel free to ignore.
|
We have better things to do than having to maintain compatibility for udev alternatives for 3 users. The way it works now, |
this allows to use alternative device manager as in void-linux/void-packages#42488