-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New package: ffmpeg7-7.1_1 #53844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ffmpeg7-7.1_1 #53844
Conversation
classabbyamp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
srcpkgs/ffmpeg7/template
Outdated
| libswresample7>=${version}_${revision}" | ||
| short_desc+=" - development files" | ||
| conflicts="ffmpeg-devel" | ||
| replaces="ffmpeg-devel>=0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to conflict/replace with other ffmpeg*-devel too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary for the other subpkgs as well? The build of the ffplay7 package failed due to the conflict field.
...
ffplay7_package() {
short_desc="Simple video player using FFmpeg and SDL2"
+ conflicts="ffplay*"
+ replaces="ffplay*>0"
pkg_install() {
vmove usr/bin/ffplay
vmove "usr/share/man/man1/ffplay*"
}
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think ffplay is fine but ffmpeg6-devel exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may need to disable ffplay in 6...or replace 6 entirely idk, depends how many deps build with 7 fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may need to disable ffplay in 6...or replace 6 entirely
Why are you considering disabling ffplay in 6? Is there a specific reason behind it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 is newer so the binary ffmpeg/ffplay may as well be 7 on the system. only a few thing use the binaries directly instead of the libraries. ill post my branch iaf.
basically:
- add depends to ffplay7 here
ffmpegandffmpeg6need the conflict for devel packages and a revbumpedffplay6becomes meta pkg likeffmpeg'sffplayis
|
will try to build to cluster-f of dep packages tonight unless you have mmdbalkhi |
|
@classabbyamp is there anything bad with #51496 ? just makes this a pita the keep flipping between onevpl and libvpl |
|
ask the maintainer of onevpl, not me |
|
https://github.com/zlice/void-packages/tree/ffmpeg7 this is dirty because of libvpl as mentioned, some revbumps and stuff are off should be 84 packages to test ffmpeg7-devel |
|
builds fine
needs work
big
|
|
Now that the vast majority of our packages build against
We want to avoid an endless string of versioned ffmpeg packages; the current split only exists because we still have stragglers that couldn't be moved to v6. |
|
i'll make a pr for the ffmpeg4 bit. don't think many people would have it installed. it's not even on my system. edit: actually what's the best way to go about that...sounds like a few steps of metapkg/replace ?
next pr (this pr?)
edit-edit: actually, do we even want to do this? ffmpeg8 will eventually come out, then it's the same song and dance again |
|
let's go with |
|
I was thinking |
|
then you can't update in waves like 6 did. everything will have to go at once (luckily a lot of packages aren't using the system ffmpeg now, so it's not as painful. but still about 80-90 packages that need updated at a single time. 30 seemed to be the sweet-spot for ci to build and be happy w/o timeouts) |
|
I think we should strive for a single ffmpeg version at any given time, then deal with spawning a new version only under extenuating circumstances. In this case, I think we should get everything currently building with ffmpeg6 building with v7 before accepting this package. |
|
so qt5 and qt6 both say 'ffmpeg >= 5' is not supported (but i think really mean ffmpeg7, as 6 appears to be building webengine) i'm sure they can be patched but other programs like chromium started using built-in ffmpeg. cuts out some codecs and new features from the system ffmpeg in kde browsers but would be less work for void members. |
|
fyi, spek-x ffmpeg7 https://github.com/MikeWang000000/spek-X/releases/tag/v0.9.4 |
|
I still have not seen a convincing argument for keeping this a separate package with a versioned name rather than moving the current Versioned package names are a necessary evil in some cases. Creating more of them in advance because we might think that someday we will want to keep a legacy |
|
looks like abby is working on axing 4. was taking a look at my 'ffmpeg-meta' pr because it wasn't building for a bit (and i didnt care bc openmw and kodi are still not released) but nothing relying on 4 should make it even easier to just do 4 -> 7 and remove 6 or something. vlc should be the only ffmpeg4 straggler |
|
And please add |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing
arch64-muslarmv7larmv6l-muslcc: @classabbyamp