-
Notifications
You must be signed in to change notification settings - Fork 0
Add Altair keyboard with vnz keymap #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Initial setup for ai03 Altair (5-row, 64-key split ergonomic): - Create vnz keymap directory with default layout - Add to qmk.json build targets Layout will be customized in subsequent commits. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @vnz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the foundational support for the ai03 Altair keyboard within the project. It establishes a new keymap, 'vnz', which provides a default layout for the keyboard's 64 keys across two layers. This initial integration allows for the compilation of firmware for the Altair with a predefined key configuration, setting the stage for future enhancements and custom features as outlined in the PR description. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new vnz keymap for the ai03/altair keyboard. The implementation includes a base layer and a function layer for navigation and F-keys. The changes look good, but I've found a critical typo in a keycode within keymap.c that will prevent compilation. I've left a specific comment with a suggestion to fix it. Once addressed, the keymap should be ready for further development as outlined in your checklist.
Full 4-layer layout for ai03 Altair (64-key split ergonomic):
Base layer:
- QWERTY with bracket progression on inner columns: [ ] { } ( ) Home End
- Thumb: GUI ALT SPC LOWER | RAISE SPC ↓ ↑
- CTRL on pinky, ESC on home row
Lower layer (Better-Shift):
- Shifted alphanumerics without holding Shift
- PgUp/PgDn on inner columns
- Tab switching (TBLT/TBRT) on thumb
Raise layer (French accents):
- é è ê ë à â ù û ü î ï ô œ ç € positioned on QWERTY base letters
- All F-keys (F1-F12) on number row including inner columns
- Horizontal arrows (← →) on thumb
Adjust layer (Lower + Raise):
- Uppercase French accents (É È Ê Ë À Â Ù Û Ü Î Ï Ô Œ Ç)
- Unicode mode switches (UC_MAC, UC_WINC, UC_LINX)
- QK_BOOT, NK_TOGG, backslash
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Thumb row (8 keys) is centered under main rows (14 keys), so offset should be 3 columns on each side, not 2. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
Initial setup for ai03 Altair (5-row, 64-key split ergonomic keyboard).
Altair Specs
Current State
Layout Reference
🤖 Generated with Claude Code