Enhancements in help message and bash completions#555
Merged
oliverkurth merged 4 commits intovmware:devfrom Jan 23, 2026
Merged
Enhancements in help message and bash completions#555oliverkurth merged 4 commits intovmware:devfrom
oliverkurth merged 4 commits intovmware:devfrom
Conversation
Contributor
|
I still see a few misalignments: There are more, just check. Typo also: I will install it also, to see if tab completion works as expected. |
oliverkurth
requested changes
Jan 7, 2026
Contributor
Author
|
Thanks for the review. Fixed everything I caught, PTAL again. |
oliverkurth
requested changes
Jan 8, 2026
oliverkurth
reviewed
Jan 22, 2026
Contributor
oliverkurth
left a comment
There was a problem hiding this comment.
Looks good (thank you!), but I have one more suggestion: use repoquery --qf instead of awk and cut for list commands. I didn't suggest this earlier because it requires tdnf >= 3.6, but I realized that that is actually fine.
Also, I realized that we should have a simpler output version for repolist, and a way to get the current history count number. We can add that in another change.
| ;; | ||
| downgrade) | ||
| opts=$(tdnf list --downgrades | awk '{print $1}' | cut -d'.' -f1) | ||
| opts=$(tdnf list --downgrades 2>/dev/null | awk '{print $1}' | cut -d'.' -f1) |
Contributor
Author
There was a problem hiding this comment.
This was missing, I added this support to repoquery.
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Currently `tdnf repoquery --upgrades` shows the entire list of packages instead of just showing uavailable updates, this patch fixes it. Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Contributor
|
Thank you, looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.