fix(readme): logo link#1657
Conversation
Signed-off-by: nolanemirot <nolan.emirot@broadcom.com>
There was a problem hiding this comment.
Hello @emirot, thanks for picking this up — the broken logo has been bothering me too. Before this lands I'd like to flag two findings and propose a small tweak that should make the fix correct on every branch that carries the same broken line.
1. The proposed image is a different logo
The original vmw-logo-photon.svg is the "PHOTON™" wordmark. The proposed replacement docs/images/photonos-logo-sm.png is a different asset — the "PHOTON OS™" wordmark. As written, the PR silently rebrands the README header rather than restoring the historical logo (which has been "PHOTON" since commit f534f99 in April 2015).
The original SVG is still available — byte-for-byte identical — on the gh-pages branch of this repo:
| File | SHA-256 |
|---|---|
Wayback Machine copy of http://storage.googleapis.com/project-photon/vmw-logo-photon.svg |
2bc244ef6c8299e3804a2d77f8ff7eca841eb30a2cba5a2723055dcf1d276b75 |
gh-pages:docs/images/photonos-logo.svg |
2bc244ef6c8299e3804a2d77f8ff7eca841eb30a2cba5a2723055dcf1d276b75 |
cmp confirms the two files are identical.
2. The same broken line lives in README.md on 10 branches, not just master
| Branch | Has the broken vmw-logo-photon.svg link |
Has docs/images/photonos-logo-sm.png |
|---|---|---|
master |
yes | yes (PR works here) |
dev |
yes | yes (same SHA as master) |
common |
yes | yes |
2.0, 3.0, 4.0 |
yes | yes |
1.0, 5.0, 6.0, main |
yes | no — the relative path would 404 |
Copy-pasting the current fix onto 1.0, 5.0, 6.0, main would replace one broken image with another.
Suggested change
Use the original SVG via a stable raw URL on gh-pages. One identical line works on every branch, removes the per-branch path dependency, drops the dead GCS bucket, and preserves the historical "PHOTON" wordmark:
-
+If switching to the "PHOTON OS" branding is actually the intent, that's of course a maintainer call — just worth calling out explicitly in the PR description so it isn't read as a pure link fix. In either case it would be great to extend the change to the other nine affected branches; I'd be happy to follow up with companion PRs if that helps.
Thanks again for the fix!
2 participants
What
Fix logo link
Why