🌱 Set the VC created at timestamp in VM CR status #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduing a new CreatedAt field in the VM's status custom resource which sets the creation timestamp from VC/VPXD on VM's creation
faisalabujabal
force-pushed
the
feat/set-vc-created-at
branch
from
c87af77 to
92b41d0
Compare
github-actions
bot
added
size/M
Minimum allowed line rate is |
bryanv
reviewed
Dec 30, 2025
| ctx, | ||
| intgFakeVMProvider, | ||
| func(ctx context.Context, vm *vmopv1.VirtualMachine) error { | ||
| vm.Status.CreatedAt = ptr.To(createdAtTime) |
Contributor
There was a problem hiding this comment.
I don't think this really adds that much
| vmCtx.VM.Status.InstanceUUID = vmCtx.MoVM.Summary.Config.InstanceUuid | ||
|
|
||
| // Only set CreatedAt if it hasn't been set yet and config.createDate is available. | ||
| // This field is immutable once set. |
Contributor
There was a problem hiding this comment.
What about for restored VMs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Introduing a new CreatedAt field in the VM's status custom resource which sets the creation timestamp from VC/VPXD on VM's creation.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # NA
Are there any special notes for your reviewer:
What do you think of the field name,
createdAt?Please add a release note if necessary: